chore: fixup paths for selinux #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also update the example on https://github.com/fedora-iot/fido-device-onboard-rs/blob/main/HOWTO.md?plain=1#L448-L454 and add a comment on https://github.com/fedora-iot/fido-device-onboard-rs/blob/main/HOWTO.md?plain=1#L493-L494 ? |
nullr0ute
reviewed
Aug 30, 2023
runcom
force-pushed
the
selinux-service-info-api-server-docs
branch
from
9a7683a
to
728da9a
Compare
|
fixed, should be good now |
7flying
reviewed
Aug 31, 2023
|
You can cherry-pick the commit from #548 (or we can merge and rebase) to make the clippy test pass |
Using the service-info-api server with selinux requires us to put anything we want to send to the device under /var/lib/fdo as that directory, and its files, will now get the correct selinux label. The previous approach opens up for security issues by leaving the process basically accessing the whole host. Signed-off-by: Antonio Murdaca <[email protected]>
Signed-off-by: Irene Diez <[email protected]>
runcom
force-pushed
the
selinux-service-info-api-server-docs
branch
from
728da9a
to
98e9479
Compare
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the service-info-api server with selinux requires us to put anything we want to send to the device under /var/lib/fdo as that directory, and its files, will now get the correct selinux label. The previous approach opens up for security issues by leaving the process basically accessing the whole host.