Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The admin tool fails to print the device credentials after the device manufacturing has been completed. #563

Closed
mmartinv opened this issue Oct 18, 2023 · 2 comments · Fixed by #564
Assignees
Labels
bug Something isn't working

Comments

@mmartinv
Copy link
Contributor

To reproduce just run the aio with the admin tool

fdo-admin-tool aio --directory=./aio run 

And run the device manufacturing process:

fdio-admin-tool aio --directory=./aio \
                device --device-credential-location=./device-credentials \
                manufacture --device-info=$(uuidgen)

The proccess will end up with:

========== MANUFACTURING CLIENT ENDED WITH STATUS: ExitStatus(unix_wait_status(0)) ==========
 INFO  fdo_admin_tool::aio::device > Device manufacturing completed
error: unexpected argument 'home' found

Usage: fdo-owner-tool dump-device-credential <PATH>

For more information, try '--help'.
Error: Error manufacturing device

Caused by:
    Owner-tool failed with status: ExitStatus(unix_wait_status(512))
@mmartinv mmartinv added the bug Something isn't working label Oct 18, 2023
@mmartinv mmartinv self-assigned this Oct 18, 2023
mmartinv added a commit to mmartinv/fido-device-onboard-rs that referenced this issue Oct 18, 2023
@nullr0ute
Copy link
Contributor

What do you mean by "print the device credentials" in this context? I don't see those details in the report

@mmartinv
Copy link
Contributor Author

mmartinv commented Oct 19, 2023

What do you mean by "print the device credentials" in this context? I don't see those details in the report

After the manufacturing process has been completed the fdo-admin-tool calls the fdo-owner-tool command to dump the device credentials. That invocation is failing and showing the above output. Instead, the output should be something like:

========== MANUFACTURING CLIENT ENDED WITH STATUS: ExitStatus(unix_wait_status(0)) ==========
 INFO  fdo_admin_tool::aio::device > Device manufacturing completed
Active: true
Protocol Version: 101
Device Info: efda0731-d5c2-4d8a-80b6-5647be536e68
Device GUID: bc44dd1c-81f1-151e-ea11-c087a4c0c181
Rendezvous Info:
	- [(DevicePort, [25, 31, 146]), (IPAddress, [68, 127, 0, 0, 1]), (OwnerPort, [25, 31, 146]), (Protocol, [1])]
Public key hash: cde99dd10aef9a624559ca930fcb6d3602a98e4950da5be2bc0d296d69b9a604d0676b0691ed01cf1f229998ca4eee21 (Sha384)
HMAC and signing key:
	HMAC key: <secret>
	Signing key: <secret>

mmartinv added a commit to mmartinv/fido-device-onboard-rs that referenced this issue Oct 19, 2023
Fix the `fdo-admin-tool aio device manufacture` command which fails
when running the `fdo-owner-tool dump-device-credential` command
after the manufacturing process has finished successfully.

Closes fdo-rs#563

Signed-off-by: Miguel Martín <[email protected]>
mmartinv added a commit to mmartinv/fido-device-onboard-rs that referenced this issue Nov 13, 2023
Fix the `fdo-admin-tool aio device manufacture` command which fails
when running the `fdo-owner-tool dump-device-credential` command
after the manufacturing process has finished successfully.

Closes fdo-rs#563

Signed-off-by: Miguel Martín <[email protected]>
@mergify mergify bot closed this as completed in #564 Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants