Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixup paths for selinux #547

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

runcom
Copy link
Contributor

@runcom runcom commented Aug 30, 2023

Using the service-info-api server with selinux requires us to put anything we want to send to the device under /var/lib/fdo as that directory, and its files, will now get the correct selinux label. The previous approach opens up for security issues by leaving the process basically accessing the whole host.

@7flying
Copy link
Contributor

7flying commented Aug 30, 2023

HOWTO.md Outdated Show resolved Hide resolved
@runcom runcom force-pushed the selinux-service-info-api-server-docs branch from 9a7683a to 728da9a Compare August 31, 2023 11:36
@runcom
Copy link
Contributor Author

runcom commented Aug 31, 2023

fixed, should be good now

HOWTO.md Outdated Show resolved Hide resolved
@7flying
Copy link
Contributor

7flying commented Aug 31, 2023

You can cherry-pick the commit from #548 (or we can merge and rebase) to make the clippy test pass

runcom and others added 2 commits August 31, 2023 14:01
Using the service-info-api server with selinux requires us to put
anything we want to send to the device under /var/lib/fdo as that
directory, and its files, will now get the correct selinux label.
The previous approach opens up for security issues by leaving the
process basically accessing the whole host.

Signed-off-by: Antonio Murdaca <[email protected]>
@runcom runcom force-pushed the selinux-service-info-api-server-docs branch from 728da9a to 98e9479 Compare August 31, 2023 12:01
@runcom
Copy link
Contributor Author

runcom commented Aug 31, 2023

You can cherry-pick the commit from #548 (or we can merge and rebase) to make the clippy test pass

done

Copy link
Contributor

@7flying 7flying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mergify mergify bot merged commit 80ed0dd into fdo-rs:main Aug 31, 2023
16 of 22 checks passed
@runcom runcom deleted the selinux-service-info-api-server-docs branch August 31, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants