Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents error response for Phone.parse/1 and Phone.parse/2 in specs #136

Closed
wants to merge 1 commit into from

Conversation

ajmath
Copy link

@ajmath ajmath commented Sep 25, 2020

Fixes #135 and maybe #101?

@sourcelevel-bot
Copy link

Hello, @ajmath! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f56395c on ajmath:135-fix-specs into 0c7c703 on fcevado:master.

@ajmath ajmath changed the title Documents error response for Phone.parse/1 and Phone.parse/2 in typespecs Documents error response for Phone.parse/1 and Phone.parse/2 in specs Sep 25, 2020
@fcevado
Copy link
Owner

fcevado commented Oct 1, 2020

closes #135

@fcevado fcevado closed this Oct 1, 2020
@ajmath
Copy link
Author

ajmath commented Oct 1, 2020

@fcevado Did you mean to close this without merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect specs for parse/2
3 participants