Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer margin, accessibility issue, use dark style #19

Merged
merged 3 commits into from
Dec 6, 2024
Merged

fix: footer margin, accessibility issue, use dark style #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd6204a
fix: footer incorrect margin
igobranco Dec 6, 2024
246963f
fix: accessibility issue on footer
igobranco Dec 6, 2024
aaee54f
feat: change footer to a dark style
igobranco Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions src/_footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,25 @@
$gray-footer: #eee !default;
$logo-color: #4e4e4e !default;
$footer-background-color: #232323 !default;
$footer-text: #d2d2d2 !default;
$logo-color: $footer-text;
$footer-social-icons: $footer-text;
$footer-links-navigation-color: $footer-text;

.footer-navigation {
background-color: $gray-footer;
background-color: $footer-background-color;
padding-top: 2rem;
padding-bottom: 2rem;
}

.footer-copyright {
color: $logo-color;
font-size: 0.7rem;
font-size: 0.9rem;
display: block;
line-height: 1.1;
padding: .8rem 0;
}

.footer-links-navigation {
color: $footer-links-navigation-color;
flex-basis: 260px;
min-width: 200px;
font-size: 0.9rem;
Expand All @@ -27,8 +33,13 @@ $logo-color: #4e4e4e !default;
padding: 0;
margin: 0;

li {
margin: 0.1rem 0.1rem 0.1rem 0;
padding: 0.1rem 0.1rem 0.1rem 0;
}

a {
color: black;
color: $footer-links-navigation-color;
}
}
}
Expand All @@ -39,6 +50,10 @@ $logo-color: #4e4e4e !default;
&__badge {
margin-right: 1.5rem;
}

a {
color: $footer-social-icons;
}
}

.footer-additional-logos {
Expand Down
2 changes: 1 addition & 1 deletion src/components/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class SiteFooter extends React.Component {
role="contentinfo"
>
<section className="footer-navigation">
<div className="container d-md-flex justify-content-between py-3">
<div className="container-xl d-xl-flex justify-content-between py-3">
<div className="footer-navigation__brand d-flex flex-column justify-content-between px-4">
<a
className="d-block"
Expand Down
6 changes: 3 additions & 3 deletions src/components/__snapshots__/Footer.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ exports[`<Footer /> renders correctly renders with a language selector 1`] = `
className="footer-navigation"
>
<div
className="container d-md-flex justify-content-between py-3"
className="container-xl d-xl-flex justify-content-between py-3"
>
<div
className="footer-navigation__brand d-flex flex-column justify-content-between px-4"
Expand Down Expand Up @@ -89,7 +89,7 @@ exports[`<Footer /> renders correctly renders without a language selector 1`] =
className="footer-navigation"
>
<div
className="container d-md-flex justify-content-between py-3"
className="container-xl d-xl-flex justify-content-between py-3"
>
<div
className="footer-navigation__brand d-flex flex-column justify-content-between px-4"
Expand Down Expand Up @@ -131,7 +131,7 @@ exports[`<Footer /> renders correctly renders without a language selector in pt-
className="footer-navigation"
>
<div
className="container d-md-flex justify-content-between py-3"
className="container-xl d-xl-flex justify-content-between py-3"
>
<div
className="footer-navigation__brand d-flex flex-column justify-content-between px-4"
Expand Down
Loading