Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract console report #114

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Extract console report #114

wants to merge 1 commit into from

Conversation

JuanVqz
Copy link
Member

@JuanVqz JuanVqz commented Jul 31, 2023

IMPORTANT: Please read the README before submitting pull requests for this project. Additionally, if your PR closes any open GitHub issue, make sure you include Closes #XXXX in your comment.

  • Add an entry to CHANGELOG.md that links to this PR under the "main (unreleased)" heading.

Description:

Will left comments in the files

Clos #103

I will abide by the code of conduct.

@JuanVqz JuanVqz mentioned this pull request Jul 31, 2023
1 task
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #114 (876e380) into main (f6f63c8) will decrease coverage by 0.07%.
The diff coverage is 97.77%.

❗ Current head 876e380 differs from pull request most recent head 9ed172d. Consider uploading reports for the commit 9ed172d to get more accurate results

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   98.37%   98.30%   -0.07%     
==========================================
  Files          17       19       +2     
  Lines         307      354      +47     
==========================================
+ Hits          302      348      +46     
- Misses          5        6       +1     
Files Changed Coverage Δ
lib/skunk/commands/status_reporter.rb 100.00% <ø> (+2.50%) ⬆️
lib/skunk/core/scorer.rb 92.85% <92.85%> (ø)
lib/skunk/commands/default.rb 100.00% <100.00%> (ø)
lib/skunk/commands/status_sharer.rb 98.27% <100.00%> (+0.60%) ⬆️
lib/skunk/generators/console_report.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JuanVqz JuanVqz force-pushed the extract-console-report branch from 9e9aae8 to 9ed172d Compare July 31, 2023 07:23
@JuanVqz
Copy link
Member Author

JuanVqz commented Mar 3, 2024

@etagwerker it would be nice if you or a contributor could move this to the final line, it seems close but haven't had the chance to check it, thanks!

@etagwerker
Copy link
Member

@JuanVqz Other than fixing the conflict, what else is missing in this PR? There are a lot of changes, so it's not easy to understand what's left...

@JuanVqz
Copy link
Member Author

JuanVqz commented Mar 4, 2024

@JuanVqz Other than fixing the conflict, what else is missing in this PR? There are a lot of changes, so it's not easy to understand what's left...

That is true, I'll find a way to update it and explain what is left, 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants