New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor model and controller to follow Rails conventions #15

Open

arielj wants to merge 2 commits into main from Issue-14-more-conventional-rails

+165 −125

arielj commented Oct 18, 2023

This PR includes different changes:

use strong parameters to permit/require parameters in the requests
use AR validations to require attributes in the report model
updates tests to send json content since it matches the information we want better
use AR serialization to handle the "report" column de/serialization

arielj added 2 commits

October 18, 2023 11:58


          Use conventions of Rails to require and validate attributes

34e1b6a


          Improve validation message and tests

83f4e4a

arielj requested a review from etagwerker

October 18, 2023 20:07

arielj linked an issue

that may be closed by this pull request

[REQUEST] Make reports#create more standard #14

Open

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet