Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary workaround for QKeras installation #1145

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented Dec 9, 2024

Description

Temporary workaround for installing without QKeras dependency since PyPI won't allow us to submit a package with direct dependencies. Relying on published version of QKeras breaks things, so there's no nice solution.

The workaround is to install qkeras if it is not already present in the environment prior to initialization of hls4ml package itself. It has been tested in various environment configurations and seems to work without breaking other stuff.

Dumbest PR so far!

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Tests

Any import of hls4ml should trigger this.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@JanFSchulte JanFSchulte merged commit cc4fbf9 into fastmachinelearning:main Dec 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants