Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove incorrect input from Constant nodes #1119

Merged
merged 1 commit into from
Nov 11, 2024
Merged

remove incorrect input from Constant nodes #1119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion hls4ml/model/layers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ def initialize(self):


class Constant(Layer):
# one could consider making this a weight attribute, but given it's transient nature, I am not sure it helps
# one could consider making this a weight attribute, but given its transient nature, I am not sure it helps
_expected_attributes = [
Attribute('value', value_type=np.ndarray),
]
Expand All @@ -371,6 +371,10 @@ def initialize(self):
dims = [f'{self.name}_{i}' for i in range(len(shape))]
quantizer = self.get_attr('quantizer')

# the graph._make_graph function sets the input node to the previous node
# if it is not set. That is incorrect for Constant nodes, so remove the input node
self.inputs = []

# Should the else clause below be None or UnspecifiedPrecisionType
precision = quantizer.hls_type if quantizer is not None else UnspecifiedPrecisionType()

Expand Down
Loading