Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, weight loading requires running from the specific directory so the relative paths match. In addition,
predict()
expects all backbends to have a format of<output_dir>/firmware
which may not be the case forever in the future (one API in particular will have a different hierarchy). With this PR we ensure the created .so file is has the weights for in absolute path, so loading it from any directory will work, and predict no longer has to change folders.Type of change
Tests
No need for new tests, all tests will fail if it doesn't work.
Checklist
pre-commit
on the files I edited or added.