Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove checks on 'padding' that were missed in previous PR #1064

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

jmitrevs
Copy link
Contributor

@jmitrevs jmitrevs commented Sep 12, 2024

Description

This removes checks on 'padding' that were inadverently missed in a previous PR (#1061), which are responsible for the failures in https://gitlab.cern.ch/fastmachinelearning/hls4ml/-/jobs/43364016

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • Other (Specify): pytest fix

Tests

The current main branch fails some pytests, as linked above. This fixes the pytest failures.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs jmitrevs added the bug label Sep 12, 2024
@vloncar vloncar merged commit 5241109 into main Sep 13, 2024
6 of 9 checks passed
@vloncar vloncar deleted the missed_padding_checks branch September 13, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants