Add ParT and UParT SONIC producer second pull request #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpedro88
reviewed
Jun 24, 2024
| constexpr unsigned n_npf_accept = 25; | ||
| constexpr unsigned n_sv_accept = 5; | ||
|
|
||
| const std::map<InputFeatures, unsigned int> N_InputFeatures{ |
There was a problem hiding this comment.
this should be nInputFeatures to follow the CMS naming rules: http://cms-sw.github.io/cms_coding_rules.html#2--naming-rules-1
(similarly for the other similar variables below)
| constexpr unsigned n_sv_accept = 5; | ||
|
|
||
| const std::map<InputFeatures, unsigned int> N_InputFeatures{ | ||
| {kChargedCandidates, 16}, |
There was a problem hiding this comment.
these could actually be vectors rather than maps, since the enum is ordered and dense. that would speed up some of the operations in the producers.
| const unsigned int target_n_npf = std::clamp(max_n_npf_counter, (unsigned int)1, (unsigned int)parT::n_npf_accept); | ||
| const unsigned int target_n_vtx = std::clamp(max_n_vtx_counter, (unsigned int)1, (unsigned int)parT::n_sv_accept); | ||
|
|
||
| const std::map<parT::InputFeatures, unsigned int> target_n { |
|
|
||
| if (taginfo.features().is_filled) { | ||
| for (std::size_t flav_n = 0; flav_n < flav_names_.size(); flav_n++) { | ||
| (*(output_tags[flav_n]))[jet_ref] = outputs_from_server[jet_n][flav_n]; |
There was a problem hiding this comment.
this can be:
(*(output_tags[flav_n]))[jet_ref] = taginfo.features().is_filled ? outputs_from_server[jet_n][flav_n] : -1.0;so that the for loop doesn't have to be repeated
| std::vector<float> inputs_UparT(const btagbtvdeep::SecondaryVertexFeatures& sv_features, UparT::InputFeatures ifeature); | ||
|
|
||
| template<class parT_features> | ||
| void parT_tensor_filler(cms::Ort::FloatArrays& data, const parT::InputFeatures ifeature, const std::vector<parT_features>& features, const unsigned int max_n, const float*& start, unsigned offset) { |
There was a problem hiding this comment.
make sure to run these commands before submitting the official PR:
scram b code-checks
scram b code-format
| const unsigned int target_n_npf = (unsigned int)UparT::n_npf_accept; | ||
| const unsigned int target_n_vtx = (unsigned int)UparT::n_sv_accept; | ||
|
|
||
| const std::map<UparT::InputFeatures, unsigned int> target_n { |
|
|
||
| if (taginfo.features().is_filled) { | ||
| for (std::size_t flav_n = 0; flav_n < flav_names_.size(); flav_n++) { | ||
| (*(output_tags[flav_n]))[jet_ref] = outputs_from_server[jet_n][flav_n]; |
| timeout = cms.untracked.uint32(300), | ||
| mode = cms.string("Async"), | ||
| modelName = cms.string("particletransformer_AK4"), # double check | ||
| modelConfigPath = cms.FileInPath("RecoBTag/Combined/data/models/particletransformer_AK4/config.pbtxt"), # this is SONIC, not currently in the CMSSW, so the models/ will be copied to this location privately |
There was a problem hiding this comment.
this comment should be removed for the official PR
| timeout = cms.untracked.uint32(300), | ||
| mode = cms.string("Async"), | ||
| modelName = cms.string("unifiedparticletransformer_AK4"), # double check | ||
| modelConfigPath = cms.FileInPath("RecoBTag/Combined/data/models/unifiedparticletransformer_AK4/config.pbtxt"), # this is SONIC, not currently in the CMSSW, so the models/ will be copied to this location privately |
There was a problem hiding this comment.
this comment should be removed for the official PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
PR validation:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Before submitting your pull requests, make sure you followed this checklist: