block_fastly_service_package: unnecessary source_code_hash conflict #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the configuration that `source_code_hash` conflicts with `content`. Regardless of how bytes are provided for the package, it stands to reason it should be possible to also provide the files hash (as computed by `fastly compute hash-files`) so the provider can correctly detect drift.
|
re: the following comment in the linked issue...
...I had a look back at the original PR #661 and I'm also not sure why I added the Have a look back over the original PR and let me know your thoughts. I'll leave this PR in your hands, but I wanted to at least comment on this PR as I was responsible for adding the original modifications. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the configuration that
source_code_hashconflicts withcontent. Regardless of how bytes are provided for the package, itstands to reason it should be possible to also provide the files hash (as
computed by
fastly compute hash-files) so the provider can correctlydetect drift.
Fixes #908