Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force refresh when service version is reverted outside of Terraform #630

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Jan 6, 2023

Fixes #629

NOTE: I tested this locally by building the provider and following the following steps...

  1. Create a new fastly_service_vcl service with two domains.
  2. Delete one of the domains and plan/apply the change (creating service version 2).
  3. Rollback the service to version 1 via the Fastly UI.
  4. Run terraform plan and it should display the same plan as step 2.
  5. Once plan is applied, then terraform show reveals service is now at version 3 and has the correct resources.

@Integralist Integralist added the bug label Jan 6, 2023
@Integralist Integralist requested review from a team and kailan and removed request for a team January 6, 2023 14:24
Copy link
Member

@kailan kailan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Integralist Integralist merged commit 959f6b8 into main Jan 9, 2023
@Integralist Integralist deleted the integralist/force-refresh branch January 9, 2023 14:24
@jonnangle
Copy link

Thanks for this @Integralist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attributes aren't refreshed if no attributes of that type exist in local state
3 participants