-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export screenshots #5
base: master
Are you sure you want to change the base?
Conversation
e0d13c2
to
ad5a1a5
Compare
class ExportOptions | ||
AVAILABLE_OPTIONS = %i[destination by_device by_locale].freeze | ||
|
||
def initialize(**options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo add document comments
9c39a1e
to
c4a4bb0
Compare
157ab94
to
c4a4bb0
Compare
c4a4bb0
to
4a6ed0d
Compare
4a6ed0d
to
a4f5dcb
Compare
Hi, when I was testing this PR, I confronted a crash during the screenshot export. Some tests don't have attachments = action_testable_summary.all_tests
.map(&:summary_ref)
.map { |ref| ref.load_object(from: path) }
.flat_map(&:activity_summaries)
.flat_map(&:subactivities)
.flat_map(&:attachments) I have solved this issue by using a select before the map attachments = action_testable_summary.all_tests.select {|x| x.summary_ref } |
This PR depends on changes in #4 so this PR includes many unnecessary changes at this moment.
You can see actual changes on this PR is here ainame/xcresult@generate-models...ainame:export-screenshots.
Prior to this PR, I've also submitted the PR that powers this gem to cover all the models that
.xcresult
file format uses. This PR implemented exporting of screenshots functionality.Additionally, I added
bin/console
andbin/setup
which are normally bundled with a newly created gem bybundler
. It is very handy for basic debugging, like runningXCResult::Parser.new(path: '...')
locally.