Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies (mostly AWS SDK) #81

Closed
wants to merge 1 commit into from
Closed

Update dependencies (mostly AWS SDK) #81

wants to merge 1 commit into from

Conversation

levibostian
Copy link
Contributor

@levibostian levibostian commented Nov 16, 2019 •
edited
Loading

Bump version of AWS SDK to latest.

I am currently using my fork's changes in an iOS project of mine and it is working good.

Closes: #71
Fixes: #84

@cndouglas cndouglas mentioned this pull request Mar 25, 2020
Closed
@kevnm67
Copy link

kevnm67 commented Mar 29, 2020

Any chance on getting this reviewed/merged? I've been using @levibostian branch since November in multiple projects without any issues.

@levibostian
Copy link
Contributor Author

levibostian commented Mar 29, 2020 •
edited
Loading

UPDATE: PR made with these changes. Keeping both PRs open for the community to decide what one to choose.

To make this PR even better, we may want to consider doing a couple of changes that I have discovered since making this original PR.

  1. Change the Gemfile ruby version from 3.1 to 3. From AWS's docs, they follow symantic versioning so we can be safe with declaring the major version only to prevent us having to update this plugin as frequently when minor changes happen.
  2. The aws ruby gem in v3 added gem modularity. Instead of us having to install aws-sdk ruby gem, we can just install aws-sdk-s3. See list of all gems

@levibostian levibostian mentioned this pull request Mar 29, 2020
Merged
@levibostian
Copy link
Contributor Author

Closing as other PR got merged

@levibostian levibostian closed this Apr 3, 2020
@levibostian levibostian deleted the aws-sdk-v3 branch April 3, 2020 15:22
@joshdholtz joshdholtz mentioned this pull request Apr 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fastlane 2.144.0 breaks compatibility Update aws-sdk version
2 participants
@levibostian @kevnm67