Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new "html_in_folder" option #30

Merged
merged 2 commits into from
Jul 31, 2017

Conversation

schluete
Copy link
Contributor

This implements #29 to have the generated HTML page be uploaded to the individual version directories.

@davibe
Copy link

davibe commented Jun 18, 2017

I need this as well so i hope to see it merged, thank you

@davibe
Copy link

davibe commented Jun 18, 2017

Another way of doing this would be to support variable in app_directory (they don't work atm) and use an empty path
i.e.

  app_directory: "diva3/v{CFBundleShortVersionString}_b{CFBundleVersion}/",
  path: "",

@joshdholtz
Copy link
Member

@schluete This looks great! Sorry for taking long time to review. Life happened 😇 Thanks for the contribution ❤️

@joshdholtz joshdholtz merged commit f9adeb6 into fastlane-community:master Jul 31, 2017
jaximan pushed a commit to jaximan/fastlane-plugin-s3 that referenced this pull request Jun 26, 2019
* option to move the generated HTML file into the version directory (issue fastlane-community#29)

* replace Date.current with Date.today
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants