Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use locally installed Ionic (from node_modules/.bin) #58

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

brunobastosg
Copy link

In my company we have a couple of Mac Minis that are used for building iOS apps in CI.

It's common for projects to have different Ionic and/or Cordova versions, so using the globally installed Ionic is no good in this case.

@janpio janpio changed the title Add the possibility to use locally installed Ionic feat: Use locally installed Ionic (from node_modules/.bin) Sep 2, 2019
@janpio
Copy link
Collaborator

janpio commented Sep 2, 2019

Thanks, this is a great feature.

Is node_modules/.bin valid on all platforms?

I think we had similar requests in the past to be able to use npx ionic or something like that, your PR should be a good template to implement that as well.

@brunobastosg
Copy link
Author

Thanks, this is a great feature.

Is node_modules/.bin valid on all platforms?

I think we had similar requests in the past to be able to use npx ionic or something like that, your PR should be a good template to implement that as well.

I know node_modules/.bin is valid on Linux & Mac OS. I'll have to test it on Windows, but it's gonna take a few days.

@brunobastosg
Copy link
Author

I replaced node_modules/.bin with File.join("node_modules", ".bin", "") (so it uses the correct path separators), but I couldn't get Fastlane to work on Windows (some problem while installing gem unf_ext).

I'm using Chocolatey to install Ruby and installed all these packages below, but nothing seems to work.

7zip.commandline 16.02.0.20170209
7zip.portable 19.0
chocolatey 0.10.15
chocolatey-core.extension 1.3.3
DotNet4.5.2 4.5.2.20140902
microsoft-visual-cpp-build-tools 14.0.25420.1
mingw 8.1.0
msys2 20180531.0.0
nodejs.install 10.16.2
ruby 2.5.3.101
ruby2.devkit 4.7.2.2013022403

@robingenz
Copy link
Contributor

node_modules/.bin is also valid on windows.
It would be great to see this feature in fastlane.

Are there any updates?

@brunobastosg
Copy link
Author

@robingenz I couldn't test in on Windows, but if you're saying it works, it's up to @janpio to merge or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants