[wip] Improve handling missing coverage info #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhkaplan
commented
Nov 10, 2021
| # Output the processed report | ||
| output_report(report) | ||
| rescue => e | ||
| markdown("Xcov not run due to error: #{e}") |
There was a problem hiding this comment.
warn or fail is more appropriate than markdown method. Also, I had some string encoding issues with displaying the error... Maybe better to leave it out?
Xcov not run due to error: �[31mError creating your coverage report - see the log above�[0m
There was a problem hiding this comment.
@nakiostudio @joshdholtz @ffittschen How do you think the error should be handled? I think rescuing a specific error type would make this plugin brittle and break functioning whenever xcov changes, but what do you think of outputting a generic error thusly:
error("Xcov-danger could not run")
Having the error info would make it easier to fix the problem, but I'm not sure where the string encoding issues are coming from...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #25