Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling a missing .xccoverage file #25

Open
ffittschen opened this issue Jan 9, 2019 · 3 comments
Open

Improve handling a missing .xccoverage file #25

ffittschen opened this issue Jan 9, 2019 · 3 comments

Comments

@ffittschen
Copy link

Hi, when there are failing unittests, there won't be a .xccoverage file generated by Xcode. Therefore, the error raised by xcov will be passed through to Danger resulting in Danger exiting with status code 1 instead of 0. This causes that danger will only print a quite generic error message instead of the rest of the report:

danger_error

In case the xcode_summary step is used, the rest of the report might even contain the failed unittests, which are now hidden to the contributors.

What do you think about adding a rescue statement to danger-xcov to handle the error gracefully and print the error message as failure in the danger report? I can create a PR if you agree with this idea.

@yhkaplan
Copy link

I for one would enjoy this!

@Kaspik
Copy link

Kaspik commented Apr 21, 2020

@ffittschen Please do! :)

@ismetanin
Copy link

That would be really convenient

yhkaplan added a commit to yhkaplan/danger-xcov that referenced this issue Nov 9, 2021
yhkaplan added a commit to yhkaplan/danger-xcov that referenced this issue Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants