perf: use node: prefix to bypass require.cache call for builtins (#477

)

* perf: use `node:` prefix to bypass require.cache call for builtins

See fastify/fastify-static#407

* docs: use `node:` prefix to bypass require.cache call for builtins

README.md

@@ -26,9 +26,9 @@ If you are looking for the documentation for the legacy callback-api please see
 
 ```js
 const fastify = require('fastify')()
-const fs = require('fs')
-const util = require('util')
-const { pipeline } = require('stream')
+const fs = require('node:fs')
+const util = require('node:util')
+const { pipeline } = require('node:stream')
 const pump = util.promisify(pipeline)
 
 fastify.register(require('@fastify/multipart'))

callback.md

@@ -11,7 +11,7 @@
 ```js
 const fastify = require('fastify')()
 const concat = require('concat-stream')
-const fs = require('fs')
+const fs = require('node:fs')
 const pump = require('pump')
 
 fastify.register(require('@fastify/multipart'))

examples/example-legacy.js

@@ -1,8 +1,8 @@
 'use strict'
 
 const fastify = require('fastify')()
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
 const pump = require('pump')
 const form = path.join(__dirname, '..', 'form.html')
 

examples/example.js

@@ -1,10 +1,10 @@
 'use strict'
 
 const fastify = require('fastify')()
-const fs = require('fs')
-const util = require('util')
-const path = require('path')
-const { pipeline } = require('stream')
+const fs = require('node:fs')
+const util = require('node:util')
+const path = require('node:path')
+const { pipeline } = require('node:stream')
 const pump = util.promisify(pipeline)
 const form = path.join(__dirname, '..', 'form.html')
 

index.js

@@ -1,18 +1,18 @@
 'use strict'
 
 const Busboy = require('@fastify/busboy')
-const os = require('os')
+const os = require('node:os')
 const fp = require('fastify-plugin')
 const eos = require('end-of-stream')
-const { createWriteStream } = require('fs')
-const { unlink } = require('fs').promises
-const path = require('path')
+const { createWriteStream } = require('node:fs')
+const { unlink } = require('node:fs').promises
+const path = require('node:path')
 const { generateId } = require('./lib/generateId')
-const util = require('util')
+const util = require('node:util')
 const createError = require('@fastify/error')
 const sendToWormhole = require('stream-wormhole')
 const deepmergeAll = require('@fastify/deepmerge')({ all: true })
-const { PassThrough, pipeline, Readable } = require('stream')
+const { PassThrough, pipeline, Readable } = require('node:stream')
 const pump = util.promisify(pipeline)
 const secureJSON = require('secure-json-parse')
 

test/big.test.js

@@ -4,11 +4,11 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
+const http = require('node:http')
 const stream = require('readable-stream')
 const Readable = stream.Readable
 const pump = stream.pipeline
-const crypto = require('crypto')
+const crypto = require('node:crypto')
 const sendToWormhole = require('stream-wormhole')
 
 // skipping on Github Actions because it takes too long

test/fix-313.test.js

@@ -4,11 +4,11 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
-const path = require('path')
-const fs = require('fs')
-const { access } = require('fs').promises
-const EventEmitter = require('events')
+const http = require('node:http')
+const path = require('node:path')
+const fs = require('node:fs')
+const { access } = require('node:fs').promises
+const EventEmitter = require('node:events')
 const { once } = EventEmitter
 
 const filePath = path.join(__dirname, '../README.md')

test/legacy/append-body.test.js

@@ -3,9 +3,9 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('./../..')
-const http = require('http')
-const path = require('path')
-const fs = require('fs')
+const http = require('node:http')
+const path = require('node:path')
+const fs = require('node:fs')
 const pump = require('pump')
 
 const filePath = path.join(__dirname, '..', '..', 'README.md')

test/legacy/big.test.js

@@ -4,13 +4,13 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('./../..')
-const http = require('http')
+const http = require('node:http')
 const stream = require('readable-stream')
 const Readable = stream.Readable
 const Writable = stream.Writable
 const pump = stream.pipeline
 const eos = stream.finished
-const crypto = require('crypto')
+const crypto = require('node:crypto')
 
 // skipping on Github Actions because it takes too long
 test('should upload a big file in constant memory', { skip: process.env.CI }, function (t) {

test/legacy/multipart.test.js

@@ -1,12 +1,12 @@
 'use strict'
-const os = require('os')
+const os = require('node:os')
 const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('./../..')
-const http = require('http')
-const path = require('path')
-const fs = require('fs')
+const http = require('node:http')
+const path = require('node:path')
+const fs = require('node:fs')
 const concat = require('concat-stream')
 const stream = require('readable-stream')
 const pump = stream.pipeline

test/multipart-ajv-file.test.js

@@ -3,11 +3,11 @@
 const test = require('tap').test
 const Fastify = require('fastify')
 const FormData = require('form-data')
-const http = require('http')
+const http = require('node:http')
 const multipart = require('..')
-const { once } = require('events')
-const fs = require('fs')
-const path = require('path')
+const { once } = require('node:events')
+const fs = require('node:fs')
+const path = require('node:path')
 
 const filePath = path.join(__dirname, '../README.md')
 

test/multipart-attach-body.test.js

@@ -4,11 +4,11 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
-const path = require('path')
-const fs = require('fs')
-const { once } = require('events')
-const { Readable } = require('stream')
+const http = require('node:http')
+const path = require('node:path')
+const fs = require('node:fs')
+const { once } = require('node:events')
+const { Readable } = require('node:stream')
 const pump = require('pump')
 const { writableNoopStream } = require('noop-stream')
 

test/multipart-big-stream.test.js

@@ -4,11 +4,11 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
-const crypto = require('crypto')
+const http = require('node:http')
+const crypto = require('node:crypto')
 const { Readable } = require('readable-stream')
 const sendToWormhole = require('stream-wormhole')
-const EventEmitter = require('events')
+const EventEmitter = require('node:events')
 const { once } = EventEmitter
 
 test('should emit fileSize limitation error during streaming', async function (t) {

test/multipart-body-schema.test.js

@@ -4,9 +4,9 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
-const path = require('path')
-const fs = require('fs')
+const http = require('node:http')
+const path = require('node:path')
+const fs = require('node:fs')
 
 const filePath = path.join(__dirname, '../README.md')
 

test/multipart-concat.test.js

@@ -4,9 +4,9 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
-const path = require('path')
-const fs = require('fs')
+const http = require('node:http')
+const path = require('node:path')
+const fs = require('node:fs')
 
 const filePath = path.join(__dirname, '../README.md')
 

test/multipart-disk.test.js

@@ -4,13 +4,13 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
-const crypto = require('crypto')
+const http = require('node:http')
+const crypto = require('node:crypto')
 const { Readable } = require('readable-stream')
-const path = require('path')
-const fs = require('fs')
-const { access } = require('fs').promises
-const EventEmitter = require('events')
+const path = require('node:path')
+const fs = require('node:fs')
+const { access } = require('node:fs').promises
+const EventEmitter = require('node:events')
 const { once } = EventEmitter
 
 const filePath = path.join(__dirname, '../README.md')

test/multipart-duplicate-save-request-file.test.js

@@ -4,10 +4,10 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
-const path = require('path')
-const fs = require('fs')
-const EventEmitter = require('events')
+const http = require('node:http')
+const path = require('node:path')
+const fs = require('node:fs')
+const EventEmitter = require('node:events')
 const { once } = EventEmitter
 
 const filePath = path.join(__dirname, '../README.md')

test/multipart-empty-body.test.js

@@ -4,8 +4,8 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
-const { once } = require('events')
+const http = require('node:http')
+const { once } = require('node:events')
 
 test('should not break with a empty request body when attachFieldsToBody is true', async function (t) {
   t.plan(5)

test/multipart-fileLimit.test.js

@@ -1,13 +1,13 @@
 'use strict'
 
-const fs = require('fs')
-const crypto = require('crypto')
+const fs = require('node:fs')
+const crypto = require('node:crypto')
 const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
-const EventEmitter = require('events')
+const http = require('node:http')
+const EventEmitter = require('node:events')
 const { once } = EventEmitter
 
 test('should throw fileSize limitation error when consuming the stream', async function (t) {

test/multipart-http2.test.js

@@ -5,8 +5,8 @@ const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
 const h2url = require('h2url')
-const path = require('path')
-const fs = require('fs')
+const path = require('node:path')
+const fs = require('node:fs')
 const sendToWormhole = require('stream-wormhole')
 
 const filePath = path.join(__dirname, '../README.md')

test/multipart-incomplete-upload.test.js

@@ -1,14 +1,14 @@
 'use strict'
 
-const util = require('util')
+const util = require('node:util')
 const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
+const http = require('node:http')
 const sleep = util.promisify(setTimeout)
 const { writableNoopStream } = require('noop-stream')
-const stream = require('stream')
+const stream = require('node:stream')
 const pipeline = util.promisify(stream.pipeline)
 
 test('should finish with error on partial upload', async function (t) {

test/multipart-json.test.js

@@ -4,7 +4,7 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
+const http = require('node:http')
 
 test('should parse JSON fields forms if content-type is set', function (t) {
   t.plan(5)

test/multipart-security.test.js

@@ -4,11 +4,11 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
-const path = require('path')
-const fs = require('fs')
-const crypto = require('crypto')
-const EventEmitter = require('events')
+const http = require('node:http')
+const path = require('node:path')
+const fs = require('node:fs')
+const crypto = require('node:crypto')
+const EventEmitter = require('node:events')
 const { once } = EventEmitter
 
 const filePath = path.join(__dirname, '../README.md')

test/multipart-small-stream.test.js

@@ -4,10 +4,10 @@ const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
-const path = require('path')
-const fs = require('fs')
-const EventEmitter = require('events')
+const http = require('node:http')
+const path = require('node:path')
+const fs = require('node:fs')
+const EventEmitter = require('node:events')
 const sendToWormhole = require('stream-wormhole')
 const { once } = EventEmitter
 

test/multipart.test.js

@@ -1,16 +1,16 @@
 'use strict'
 
-const util = require('util')
+const util = require('node:util')
 const test = require('tap').test
 const FormData = require('form-data')
 const Fastify = require('fastify')
 const multipart = require('..')
-const http = require('http')
-const path = require('path')
-const fs = require('fs')
+const http = require('node:http')
+const path = require('node:path')
+const fs = require('node:fs')
 const concat = require('concat-stream')
-const stream = require('stream')
-const { once } = require('events')
+const stream = require('node:stream')
+const { once } = require('node:events')
 const pump = util.promisify(stream.pipeline)
 const sendToWormhole = require('stream-wormhole')
 

tester.js

@@ -1,7 +1,7 @@
 'use strict'
 
-const http = require('http')
-const Readable = require('stream').Readable
+const http = require('node:http')
+const Readable = require('node:stream').Readable
 const FormData = require('form-data')
 const pump = require('pump')
 const knownLength = 1024 * 1024 * 1024