Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility with Python 3.13 #575

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

christophe-david
Copy link
Contributor

@christophe-david christophe-david commented Oct 29, 2024

This PR brings compatibility with Python 3.13.

Dev issue:

There is one drawback: the poetry exportcommand that generates docs/requirements.txt is unable to succeed (failing with a message such as Dependency walk failed at numpy). Apparently, this problem is expected to be solved by python-poetry/poetry#9427, that should come with Poetry 2.0.

In the meantime, my workaround is, whenever poetry.lock is modified:

  • deactivating pre-commit hooks (easy with PyCharm with commit options in the commit dialog)
  • modifying pyproject.toml to remove all "duplicate" dependencies:
     numpy = [
         { version = ">=1.23.2, <3", python = "<3.13" },
         { version = "^2.1", python = "^3.13" }
     ]
    becomes
    numpy = [
        { version = ">=1.23.2, <3", python = "<3.13" },
    ]
    To be remembered: be sure to keep dependencies that match Python version in .readthedocs.yaml (currently 3.10)
  • running manually poetry export --with doc --without-hashes -odocs/requirements.txt -frequirements.txt
  • cancelling modifications in pyproject.toml
  • committing changes in fine docs/requirements.txt

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (0eb2816) to head (f214f05).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
- Coverage   91.91%   91.86%   -0.05%     
==========================================
  Files         100      100              
  Lines        6183     6185       +2     
  Branches      973      973              
==========================================
- Hits         5683     5682       -1     
- Misses        334      335       +1     
- Partials      166      168       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant