plugin complement #409
Merged
plugin complement #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophe-david
force-pushed
the
issue-393_plugin-complement
branch
2 times, most recently
from
bbef8ab
to
3feba43
Compare
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
+ Coverage 90.89% 91.90% +1.00%
==========================================
Files 201 203 +2
Lines 8153 8409 +256
Branches 854 915 +61
==========================================
+ Hits 7411 7728 +317
+ Misses 586 504 -82
- Partials 156 177 +21
Continue to review full report at Codecov.
|
Strangely enough, GitHub workflows have now problems finding tests/testing_utilities.
…y one is available
get_plugin_configuration_file_list() is enough for the job.
…ration_file_list())
christophe-david
force-pushed
the
issue-393_plugin-complement
branch
2 times, most recently
from
90237d7
to
c42545f
Compare
christophe-david
force-pushed
the
issue-393_plugin-complement
branch
from
c42545f
to
7bb48ed
Compare
ScottDelbecq
approved these changes
Jan 23, 2022
| The command :code:`poetry build` will create a :code:`dist` folder with two files: | ||
|
|
||
| :code:`ST_drive_models-1.0.0.tar.gz` and :code:`ST_drive_models-1.0.0-py3-none-any.whl` | ||
| (or something like this). | ||
|
|
||
| You may then have sent any of those two files to another user, who may then install your models | ||
| using :code:`pip` with: |
There was a problem hiding this comment.
In the section "Publishing" I would underline that to publish on PyPi the package name will be the one provided in the field name in the pyproject.toml. Therefore, the publisher shall check that the chosen package name is not already taken on PyPi.
There was a problem hiding this comment.
Agreed. Done in a64d130.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an enhanced plugin system and closes #393.
It contains following modifications:
fastoad.pluginsas group name instead offastoad_modelfastoad_modelis still usable, though not mentioned anymore in RTD documentation. It works the same as before, i.e. it expects to have only FAST-OAD modules in the declared plugin package.FastoadLoader. Then the loading is not made anymore at startup, which greatly speeds up commands likefastoad -horfastoad -v.fastoad.apinow contains acreate_notebooks()method.contest.py. It has been rather painful to achieve that 😅.pkg_resourceshas been removed to useimportlib.metadataas it is now recommended.tests/testing_utilities.pyhas been moved tosrc/fastoad/_utils/testing.pyso that there shouldn't be anymore warning when importing copied models in other projects.