forked from JoshKeegan/xRetry
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from head repo #4
Open
chris-richards-puregym
wants to merge
252
commits into
farum12:master
Choose a base branch
from
JoshKeegan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v2...v3) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 3. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v2...v3) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ions/upload-artifact-3
…ions/download-artifact-3
Upgrade Specflow to 3.9.69
Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.4.3 to 2.4.4. - [Release notes](https://github.com/xunit/visualstudio.xunit/releases) - [Commits](https://github.com/xunit/visualstudio.xunit/commits) --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
….visualstudio-2.4.4
Bump Specflow to 3.9.74
Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.4.4 to 2.4.5. - [Release notes](https://github.com/xunit/visualstudio.xunit/releases) - [Commits](https://github.com/xunit/visualstudio.xunit/commits) --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
….visualstudio-2.4.5
Bumps [Microsoft.TestPlatform.ObjectModel](https://github.com/microsoft/vstest) from 17.1.0 to 17.2.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v17.1.0...v17.2.0) --- updated-dependencies: - dependency-name: Microsoft.TestPlatform.ObjectModel dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…stPlatform.ObjectModel-17.2.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.1.0 to 17.2.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v17.1.0...v17.2.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…T.Test.Sdk-17.2.0
Note that it's a copy/paste of xRetry.SpecFlow, but having its own section is intentional. If Reqnroll is actively developed, the instructions to use both frameworks may be identical today, but could drift over time.
Now applies to both SpecFlow & Reqnroll
Untested, but the idea is that versions are still in the Makefile, but now separated per package. Releases are now triggered via tags, e.g. xRetry_v1.9.0 or xRetry.Reqnroll_v1.0.0-alpha1. The tag name prefix is what will trigger the release of that specific package. Note: the version in the tag is for info only (git history & GH releases). The actual package version deployed will be what is in the makefile, and if it's a Reqnroll or SpecFlow plugin package, the xRetry version they depend on will also be from the Makefile.
Removed thinking they were no longer required, but was looking at the runtime plugin docs. Generator plugins for Reqnroll work the same as SpecFlow & require this so MSBuild knows to load the plugin.
--no-symbols does not take an argument, so the same nupkg was being listed twice in the push. The second attempt would always fail with a 409 since it had just been pushed.
Upgrades all packages except Reqnroll, which caused errors.
After SpecFlow 3.3.30 these are no longer required if using a unit test provider nuget package (in our case SpecFlow.xUnit). The same applies for Reqnroll, but since it forks SpecFlow 4 it was never required when used with the xunit plugin.
Fixes #250, which was a bug in Reqnroll preventing us from upgrading to 2.1.0, but is fixed in 2.1.1.
Bumps [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 6.12.1 to 6.12.2. - [Release notes](https://github.com/fluentassertions/fluentassertions/releases) - [Changelog](https://github.com/fluentassertions/fluentassertions/blob/develop/AcceptApiChanges.ps1) - [Commits](fluentassertions/fluentassertions@6.12.1...6.12.2) --- updated-dependencies: - dependency-name: FluentAssertions dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…ions-6.12.2 Bump FluentAssertions from 6.12.1 to 6.12.2
Only a single .NET standard one is built
It detects that lib\* assemblies are listed for multiple target frameworks, but dependencies are not separated by framework & warns about this. The current guidance is to separate dependencies by target framework, even if the dependencies are identical. Note that I haven't applied the same change to xRetry.Specflow, since it didn't warn for that. That seems to be because the different files are under build\*, not lib\* or ref\*... From the docs (https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu5128): If you are using a custom nuspec file, we recommend each TFM for which lib/ or ref/ assemblies exist should have a matching dependency group, even if the dependencies are the same as the next compatible TFM. For example, if a package contains netstandard1.0 and netstandard2.0 assemblies, and the dependencies are the same for both, we recommend both TFMs be listed as dependency groups with duplicate dependency items. Note that the TFM identifier used in the assembly paths use a different format to the TFM identifier used in dependency groups. The warning message specifies the correct name to use in the dependency group. If your package does not have any dependencies for that target framework, use an empty group
Should make logs easier to read
The buildstats.info service that was being used to generate the badges has been shut down. Switched to shields.io & reformatted how we show them so that it's easier to understand the data you're being shown.
Looks like I accidentally committed this almost 2 years ago and haven't noticed it since...
Bumps [Microsoft.TestPlatform.ObjectModel](https://github.com/microsoft/vstest) from 17.11.1 to 17.12.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.11.1...v17.12.0) --- updated-dependencies: - dependency-name: Microsoft.TestPlatform.ObjectModel dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…stPlatform.ObjectModel-17.12.0 Bump Microsoft.TestPlatform.ObjectModel from 17.11.1 to 17.12.0
Bumps [Microsoft.TestPlatform.ObjectModel](https://github.com/microsoft/vstest) and [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest). These dependencies needed to be updated together. Updates `Microsoft.TestPlatform.ObjectModel` from 17.12.0 to 17.12.0 - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.12.0...v17.12.0) Updates `Microsoft.NET.Test.Sdk` from 17.11.1 to 17.12.0 - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.11.1...v17.12.0) --- updated-dependencies: - dependency-name: Microsoft.TestPlatform.ObjectModel dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 6.12.2 to 7.0.0. - [Release notes](https://github.com/fluentassertions/fluentassertions/releases) - [Changelog](https://github.com/fluentassertions/fluentassertions/blob/develop/AcceptApiChanges.ps1) - [Commits](fluentassertions/fluentassertions@6.12.2...7.0.0) --- updated-dependencies: - dependency-name: FluentAssertions dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ions-7.0.0 Bump FluentAssertions from 6.12.2 to 7.0.0
Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) and [Microsoft.TestPlatform.ObjectModel](https://github.com/microsoft/vstest). These dependencies needed to be updated together. Updates `xunit.runner.visualstudio` from 2.8.2 to 3.0.0 - [Release notes](https://github.com/xunit/visualstudio.xunit/releases) - [Commits](xunit/visualstudio.xunit@2.8.2...3.0.0) Updates `Microsoft.TestPlatform.ObjectModel` from 17.12.0 to 17.12.0 - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.12.0...v17.12.0) --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.TestPlatform.ObjectModel dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to bring the code up to date with the head repo https://github.com/JoshKeegan/xRetry