Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composer、PSR-4 #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

composer、PSR-4 #11

wants to merge 1 commit into from

Conversation

xcorp1986
Copy link

详见changelog
demo基本跑通，个别notice可以留意一下

@fanfank
Copy link
Owner

fanfank commented Oct 31, 2017

哈喽 @xcorp1986 ，很感谢你为这个项目做了这些更与时俱进的改动！
但是目前 Phpfetcher 暂时仍然希望保留原本的代码结构，主要原因是我个人目前比较少去维护这个项目，相关的文档、demo等也要逐个进行新代码的适配。
在后续的PHP项目中（如果我会开发的话···），一定会采用更与时俱进的方式去完成

@xcorp1986
Copy link
Author

代码结构差不多，主要是psr-4和命名空间的形式更加一目了然，偶然见到这个项目，手痒pr了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xcorp1986 @fanfank