-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring is all you need #98
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 61.40% 61.48% +0.07%
==========================================
Files 199 199
Lines 20120 20176 +56
==========================================
+ Hits 12355 12405 +50
- Misses 7765 7771 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being annoying about the tests midway of this PR. I just saw that the coverage of the patch is really low, and I think that we have no (dedicated) test for SelfPacedDomainParam
. Would you please add some? It doesn't need to be anything fancy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for addressing all my comments
@fdamken I font really understand wh the it said that some I re-ran it now. |
It's probably because my PR comes from another repo, so it should be fine. Only the reporting fails, the test themselves pass. |
Includes #96, #99, and #100.