Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring is all you need #98

Merged
merged 27 commits into from
Oct 29, 2023
Merged

Refactoring is all you need #98

merged 27 commits into from
Oct 29, 2023

Conversation

fdamken
Copy link
Collaborator

@fdamken fdamken commented Oct 8, 2023

Includes #96, #99, and #100.

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #98 (1e19a6a) into master (93055bb) will increase coverage by 0.07%.
The diff coverage is 24.06%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   61.40%   61.48%   +0.07%     
==========================================
  Files         199      199              
  Lines       20120    20176      +56     
==========================================
+ Hits        12355    12405      +50     
- Misses       7765     7771       +6     
Flag Coverage Δ
unittests 61.48% <24.06%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Pyrado/tests/test_domain_randomization.py 99.04% <100.00%> (+0.15%) ⬆️
...do/pyrado/domain_randomization/domain_parameter.py 64.82% <94.44%> (+12.89%) ⬆️
Pyrado/pyrado/sampling/parallel_evaluation.py 37.50% <0.00%> (ø)
Pyrado/pyrado/algorithms/meta/spdr.py 0.00% <0.00%> (ø)

@famura famura self-assigned this Oct 13, 2023
@fdamken fdamken requested a review from famura October 15, 2023 18:14
Copy link
Owner

@famura famura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being annoying about the tests midway of this PR. I just saw that the coverage of the patch is really low, and I think that we have no (dedicated) test for SelfPacedDomainParam. Would you please add some? It doesn't need to be anything fancy

@fdamken fdamken changed the title Clean up SPDR Refactoring is all you need Oct 22, 2023
famura
famura previously approved these changes Oct 23, 2023
Copy link
Owner

@famura famura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for addressing all my comments

@famura
Copy link
Owner

famura commented Oct 23, 2023

@fdamken I font really understand wh the Run Tests action failed with
Error: The process '/home/runner/work/SimuRLacra/SimuRLacra/Pyrado/cc-reporter' failed with exit code 255

it said that some CC_..._ID is missing. Maybe we need to add this secret to the workflow. But then, I'm confused why PR #100 is passing

I re-ran it now.

@famura
Copy link
Owner

famura commented Oct 23, 2023

@famura famura mentioned this pull request Oct 27, 2023
@fdamken
Copy link
Collaborator Author

fdamken commented Oct 27, 2023

Still the same error: https://github.com/famura/SimuRLacra/actions/runs/6606008836/job/17950282655?pr=98#step:6:795

Any ideas @miterion @fdamken ?

It's probably because my PR comes from another repo, so it should be fine. Only the reporting fails, the test themselves pass.

@famura famura merged commit 2477928 into famura:master Oct 29, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants