fix: canRequestHistory is true while requestHistory throws an excepti… #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on when events is empty
mrmcoding88
approved these changes
Oct 28, 2023
nico-famedly
requested changes
Nov 2, 2023
| @@ -75,7 +75,6 @@ class Timeline { | |||
| bool _collectHistoryUpdates = false; | |||
|
|
|||
| bool get canRequestHistory { | |||
| if (events.isEmpty) return true; | |||
| return room.prev_batch != null && events.last.type != EventTypes.RoomCreate; | |||
There was a problem hiding this comment.
You can only access events.last, if events is not empty.
There was a problem hiding this comment.
for the normal room history, events should never have to be empty, since we should always be able to request our own history for our join event at least. This also might cause issues, since possibly on the first history pagination a timeline has no prev_batch token and is empty, if you just want to request the history for an arbitrary room? Not sure.
There was a problem hiding this comment.
okay true, somehow I have missread the whole method. Will close this then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on when events is empty