Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: incrementally add left rooms to archive #1571

Merged
merged 5 commits into from
Nov 2, 2023
Merged

chore: incrementally add left rooms to archive #1571

merged 5 commits into from
Nov 2, 2023

Conversation

TheOneWithTheBraid
Copy link
Contributor

  • store left rooms in archive during sync (as well as they are removed on join already)
  • refactor room archive code
  • fix typo

Internal reference: SMC-385

@TheOneWithTheBraid TheOneWithTheBraid force-pushed the braid/store-left-rooms-in-archive branch from 1b82c54 to 2f73120 Compare September 22, 2023 08:21
techno-disaster
techno-disaster suggested changes Oct 2, 2023
View reviewed changes
lib/src/client.dart Outdated Show resolved Hide resolved
lib/src/client.dart Show resolved Hide resolved
@TheOneWithTheBraid TheOneWithTheBraid force-pushed the braid/store-left-rooms-in-archive branch 3 times, most recently from bfbefc1 to 78ab5ec Compare October 3, 2023 06:36
techno-disaster
techno-disaster previously approved these changes Oct 3, 2023
View reviewed changes
@TheOneWithTheBraid TheOneWithTheBraid changed the title chore: incrementally add left rooms to archive Draft: chore: incrementally add left rooms to archive Oct 3, 2023
@TheOneWithTheBraid TheOneWithTheBraid force-pushed the braid/store-left-rooms-in-archive branch 2 times, most recently from 41d54da to da96871 Compare October 3, 2023 12:28
@TheOneWithTheBraid
Copy link
Contributor Author

It's now ready so far but maybe in regard of the comment I sent in [matrix] we might consider still waiting merging this up to the next weekly.

@TheOneWithTheBraid TheOneWithTheBraid force-pushed the braid/store-left-rooms-in-archive branch from da96871 to 78ab5ec Compare October 4, 2023 10:17
@TheOneWithTheBraid TheOneWithTheBraid changed the title Draft: chore: incrementally add left rooms to archive chore: incrementally add left rooms to archive Oct 4, 2023
@TheOneWithTheBraid
Copy link
Contributor Author

Ready for review, @techno-disaster !

nico-famedly
nico-famedly previously approved these changes Oct 10, 2023
View reviewed changes
@nico-famedly
Copy link
Member

Well, of course the archive room test fails now, since there will be archived rooms already in the test possibly :)

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@TheOneWithTheBraid
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.✅ TheOneWithTheBraid❌ Clemens-ToegelYou have signed the CLA already but the status is still pending? Let us recheck it.

@Clemens-Toegel CLA required.

@TheOneWithTheBraid
Copy link
Contributor Author

@nico-famedly Could you start a pipeline ?

@nico-famedly
Copy link
Member

This seems to still fail analyzer checks ftr :)

@nico-famedly
Copy link
Member

(Changes still fail the formatting check it seems)

TheOneWithTheBraid and others added 3 commits October 20, 2023 14:04
@TheOneWithTheBraid
chore: incrementally add left rooms to archive
053dddb 
- store left rooms in archive during sync (as well as they are removed
  on join already)
- refactor room archive code
- fix typo

Internal reference: SMC-385

Signed-off-by: The one with the braid <[email protected]>
@Clemens-Toegel @TheOneWithTheBraid
chore: store states to archived rooms (#1)
0ec6a64 
* chore: store states to archived rooms

* chore: PR fix

---------

Co-authored-by: Clemens Toegel <[email protected]>
@Clemens-Toegel @TheOneWithTheBraid
chore: remove archived room on forget (#2)
f1fd6f4 
Co-authored-by: Clemens Toegel <[email protected]>
@TheOneWithTheBraid TheOneWithTheBraid force-pushed the braid/store-left-rooms-in-archive branch from b40860d to 3f170b3 Compare October 20, 2023 12:05
nico-famedly
nico-famedly reviewed Oct 20, 2023
View reviewed changes
lib/src/client.dart Outdated Show resolved Hide resolved
@TheOneWithTheBraid
fix: Code style
5dea95f 
Signed-off-by: The one with the braid <[email protected]>
@TheOneWithTheBraid TheOneWithTheBraid force-pushed the braid/store-left-rooms-in-archive branch from 3f170b3 to 5dea95f Compare October 20, 2023 12:59
@nico-famedly nico-famedly merged commit 23776e5 into famedly:main Nov 2, 2023
9 checks passed
@nico-famedly
Copy link
Member

Finally. Never go on holiday, while a merge is still pending, I guess... Sorry about the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nico-famedly nico-famedly nico-famedly approved these changes

@techno-disaster techno-disaster techno-disaster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheOneWithTheBraid @nico-famedly @CLAassistant @techno-disaster @Clemens-Toegel