fix: fixed hardcoded historyCount #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
krille-chan
approved these changes
Aug 8, 2023
auto-merge was automatically disabled
August 8, 2023 14:30
Head branch was pushed to by a user without write access
PhantomRay
force-pushed
the
PhantomRay-patch-1
branch
from
4078f7a to
c4844f3
Compare
|
Hi there, can you please do something to get this merged? |
|
Hey, you must use conventional commits for this repository |
auto-merge was automatically disabled
August 29, 2023 11:51
Merge queue setting changed
|
Our CI requires commit messages to be formatted as conventional commits. We would really like to merge your contribution, however this requires the CI to pass. Can you rewrite your commit message to use a lower-case "fix" so that we can merge this? Thank you very much for the contribution though and I hope we can merge this soon! |
PhantomRay
force-pushed
the
PhantomRay-patch-1
branch
from
c4844f3 to
77ba971
Compare
PhantomRay
changed the title
|
Done. |
krille-chan
force-pushed
the
PhantomRay-patch-1
branch
from
315853b to
4b51c1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
Found a bug in _requestEvents.
historyCountis supposed to be applied tolimit, however it is using Room.DefaultHistoryCount.Also, is it possible to filter event types? Otherwise, when retrieving historical chat, there might be events not supposed to be shown.