Merge pull request #1978 from famedly/krille/fix-ci-does-not-end

chore: Dispose all clients in test
famedly · Dec 18, 2024 · 01e6633 · 01e6633
2 parents 9777dfb + e2f37c2
commit 01e6633
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/app.yml b/.github/workflows/app.yml
@@ -129,7 +129,7 @@ jobs:
       - name: Run tests
         run: |
           dart pub get
-          dart test test/box_test.dart --platform chrome --fail-fast
+          dart test test/box_test.dart --platform chrome
 
   pub-dev-dry-run:
     runs-on: ubuntu-latest

diff --git a/scripts/test.sh b/scripts/test.sh
@@ -6,7 +6,7 @@ if [ -n "$NO_OLM" ]; then
     tagFlag="-x olm"
 fi
 
-dart test --concurrency=$thread_count --coverage=coverage_dir $tagFlag --fail-fast
+dart test --concurrency=$thread_count --coverage=coverage_dir $tagFlag
 TEST_CODE=$?
 
 # lets you do more stuff like reporton

diff --git a/test/client_test.dart b/test/client_test.dart
@@ -109,7 +109,7 @@ void main() {
     });
 
     test('Login', () async {
-      final matrix = Client(
+      matrix = Client(
         'testclient',
         httpClient: FakeMatrixApi(),
         databaseBuilder: getDatabase,