fix:Do not output information that contains confidential data. #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @pyama86! It looks like this is your first PR to falcosecurity/plugins 🎉 |
Signed-off-by: Kazuhiko Yamashita <[email protected]>
pyama86
force-pushed
the
disable-output
branch
from
4ab7fd0 to
aba2141
Compare
leogr
approved these changes
Sep 18, 2024
|
LGTM label has been added. Git tree hash: fd4ef21e4eb34711041e866da414972c5dd7579f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, pyama86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alacuku
reviewed
Sep 18, 2024
|
Thank you for merging. I always appreciate your wonderful contributions. |
leogr
added a commit
that referenced
this pull request
Nov 19, 2024
Since #528 is introducing a backward incompatible change within the ruleset Signed-off-by: Leonardo Grasso <[email protected]>
poiana
pushed a commit
that referenced
this pull request
Nov 19, 2024
Since #528 is introducing a backward incompatible change within the ruleset Signed-off-by: Leonardo Grasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
This rule has an issue where it detects a configmap that seems to contain confidential information, but still outputs its content. For example, the content could potentially be notified to Slack. Therefore, it would be better not to output the object's content in this case.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: