Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added keycloak plugin to registry.yaml #527

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

mattiaforc
Copy link
Contributor

@mattiaforc mattiaforc commented Sep 11, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area registry

What this PR does / why we need it:

Introduced a new Falco plugin with source and extractor capabilities for Keycloak user/admin events.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana
Copy link
Contributor

poiana commented Sep 11, 2024

Welcome @mattiaforc! It looks like this is your first PR to falcosecurity/plugins 🎉

@poiana poiana added the size/S label Sep 11, 2024
@poiana poiana requested review from leogr and mstemm September 11, 2024 17:31
Signed-off-by: Mattia Forcellese <[email protected]>
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR and your plugin are OK for me (thanks and congrats), but I don't see any OCI packages related to your repo, even if the workflow is correct. Do you know why?

@mattiaforc
Copy link
Contributor Author

Oh, it looks like that packages that were created while the repository was private remain private even if the repository's visibility changes. I set it to public now and I managed to pull it:

docker pull ghcr.io/mattiaforc/falco-keycloak-plugin/plugin/keycloak:0.1 

Thanks for the swift reply and feedback!

@Issif
Copy link
Member

Issif commented Sep 12, 2024

Perfect. All good to me. Cc @leogr

@poiana
Copy link
Contributor

poiana commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, mattiaforc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Sep 13, 2024

LGTM label has been added.

Git tree hash: 85868649c567a2d44863e8aec99e000df68aec9d

@poiana poiana merged commit ece830a into falcosecurity:main Sep 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants