update(dummy_c): create a custom CI workflow for dummy_c
#382
Conversation
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
this file will be used also by the k8smeta plugin
There was a problem hiding this comment.
we cannot rely on the codeQL autobuild mode for complex cpp projects, dummy_c was a sort of exception because it is straightforward and doesn't have dependencies, but in order to follow a clear approach, we will have a general codeQL job for golang plugins and a dedicated codeQL job for each cpp plugin
There was a problem hiding this comment.
dedicated CI for the dummy_c plugin
There was a problem hiding this comment.
just applied clang-format on this file
Rules files suggestions |
|
LGTM label has been added. Git tree hash: 477cfbecbf070d252dffd185877478e75d8084b9
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind design
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
This change is because we cannot use codeQL autobulid mode for complex cpp plugins (see #378). So the idea is to create a custom workflow for each cpp plugin (in this case dummy_c) with a
buildjob (that runscodeQL) and a formatting job.In the same way, the
k8smetaplugin will have a dedicated workflow with abuild-and-testjob (that runscodeQL) and a formatting job.Which issue(s) this PR fixes:
Special notes for your reviewer: