Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/gcp): update extract function #361

Conversation

lorenzo-merici
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana
Copy link
Contributor

poiana commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lorenzo-merici
Once this PR has been reviewed and has the lgtm label, please assign ahmedameenaim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

Rules files suggestions

gcp_auditlog_rules.yaml

Comparing 7164896980320f7138d29a5b13ae102df5e79d08 with latest tag gcpaudit-0.2.2

No changes detected

@jasondellaluce
Copy link
Contributor

/close

Closing this one after discussing it with the contributor. The rationale is that we don't want to move from the current behavior of returning NULL when a field is missing. The correct semantics of Falco is to check whether a field exists or not with the exists operator in case it can return null.

@poiana poiana closed this Oct 13, 2023
@poiana
Copy link
Contributor

poiana commented Oct 13, 2023

@jasondellaluce: Closed this PR.

In response to this:

/close

Closing this one after discussing it with the contributor. The rationale is that we don't want to move from the current behavior of returning NULL when a field is missing. The correct semantics of Falco is to check whether a field exists or not with the exists operator in case it can return null.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants