Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins/gcp): extract more gcp fields #332

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

SKosier
Copy link
Contributor

@SKosier SKosier commented Sep 1, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

/area plugins

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Rules files suggestions

gcp_auditlog_rules.yaml

Comparing 6510084ad72a51948d3057f2d963c912281985bc with latest tag gcpaudit-0.1.0

No changes detected

@SKosier SKosier force-pushed the gcp/extract-more-fields branch 2 times, most recently from c8821ff to 6c49506 Compare September 11, 2023 12:29
@SKosier SKosier marked this pull request as ready for review September 11, 2023 12:29
@poiana poiana requested a review from mstemm September 11, 2023 12:29
@github-actions
Copy link

Rules files suggestions

gcp_auditlog_rules.yaml

Comparing f0626943867f1ecf0516163770a76e45b9e1ea75 with latest tag gcpaudit-0.1.0

No changes detected

@SKosier SKosier force-pushed the gcp/extract-more-fields branch 2 times, most recently from d6a5ee2 to 650347b Compare September 12, 2023 14:41
@SKosier SKosier force-pushed the gcp/extract-more-fields branch from 650347b to f47edbb Compare September 12, 2023 15:54
@github-actions
Copy link

Rules files suggestions

gcp_auditlog_rules.yaml

Comparing faa2983d57149dc3a49b1b1a004161f68071b4b6 with latest tag gcpaudit-0.1.2

No changes detected

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, SKosier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Sep 12, 2023

LGTM label has been added.

Git tree hash: cbbde64303ff9a805b5ac9d32d02ce2cf79a6b3a

@poiana poiana merged commit 01209e3 into falcosecurity:master Sep 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants