cleanup(userspace/libsinsp): drop sinsp m_suppressed_comms unused field

[FedeDP]

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area libsinsp

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[FedeDP]

Noticed while working on #2190 .
/milestone 0.20.0

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Perf diff from master - unit tests

    11.72%     -1.92%  [.] sinsp_parser::reset
     9.14%     +1.03%  [.] sinsp::next
     6.82%     +0.94%  [.] sinsp_evt::get_type
     3.22%     +0.66%  [.] sinsp_evt::load_params
     3.28%     -0.53%  [.] sinsp_parser::process_event
     1.87%     +0.46%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     1.99%     +0.44%  [.] next
     3.52%     -0.36%  [.] sinsp_thread_manager::find_thread
     2.80%     +0.34%  [.] sinsp_thread_manager::get_thread_ref
     0.32%     +0.30%  [.] sinsp_fdtable::find

Heap diff from master - unit tests

peak heap memory consumption: 48B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0082         +0.0081           146           147           146           147
BM_sinsp_split_median                                          +0.0118         +0.0117           145           147           145           147
BM_sinsp_split_stddev                                          -0.6587         -0.6588             3             1             3             1
BM_sinsp_split_cv                                              -0.6615         -0.6616             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0798         -0.0799            61            57            61            57
BM_sinsp_concatenate_paths_relative_path_median                -0.0789         -0.0790            61            57            61            57
BM_sinsp_concatenate_paths_relative_path_stddev                +1.3453         +1.3553             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +1.5487         +1.5598             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0047         -0.0048            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   -0.0006         -0.0007            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.6964         -0.6962             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.6949         -0.6947             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0924         -0.0924            65            59            65            59
BM_sinsp_concatenate_paths_absolute_path_median                -0.0922         -0.0922            65            59            65            59
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3251         -0.3261             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.2564         -0.2575             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0006         +0.0005           395           395           395           395
BM_sinsp_split_container_image_median                          -0.0016         -0.0017           395           395           395           395
BM_sinsp_split_container_image_stddev                          +0.1176         +0.1199             2             2             2             2
BM_sinsp_split_container_image_cv                              +0.1170         +0.1193             0             0             0             0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.20%. Comparing base (0b53bd7) to head (550c2ff).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2191      +/-   ##
==========================================
- Coverage   75.20%   75.20%   -0.01%     
==========================================
  Files         259      259              
  Lines       33890    33889       -1     
  Branches     5801     5801              
==========================================
- Hits        25487    25486       -1     
  Misses       8403     8403              

Flag	Coverage Δ
libsinsp	75.20% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[FedeDP]

Notice how we made an object class for that here.