Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracking] Improve code documentation #1747

Open
sgaist opened this issue Mar 13, 2024 · 6 comments
Open

[tracking] Improve code documentation #1747

sgaist opened this issue Mar 13, 2024 · 6 comments
Labels
help wanted Extra attention is needed kind/documentation Improvements or additions to documentation

Comments

@sgaist
Copy link
Contributor

sgaist commented Mar 13, 2024

This ticket is a follow up of today's community meeting.

TLDR: improve the code base documentation so that users of the libraries as well as new (and old) contributors have an easier time going through it.

The longer story: while the libs code base is not void of documentation, it's also not completely documented and there are often a mix of doxygen and documentation formatted as comments (not related to comments in code). This make understanding how things are working more complicated than needed.

As an example of project that is heavily documented: the Qt framework. All the classes are fully documented. When needed, code snippets are present as well. And there are quite a lot of examples to get started.

Without going as far as Qt, it would be a nice long term goal to have Falco's libraries fully documented. This would allow to generate the API documentation which is always a nice to have when making use of a library.

There are several (complimentary) ways that this could be achieved:

  • Each time someone modifies a function that is not yet documented, add it
  • Each time a new API is added, mandatory document it
  • Have documentation sprints where people gather to do just that: take the time to document

This does not need to be the work of a single person.

One thing that could be done in that context is the creation of a group/team of people interested in this topic. They could help plan out the work on the long term, prepare guidelines, help review submission (style is as important as accuracy), etc. This would allow to have a consistent work done through all the Falco projects.

@sgaist sgaist added the kind/documentation Improvements or additions to documentation label Mar 13, 2024
@incertum
Copy link
Contributor

Fully supportive, on top I actually see an urgent need to fully define our coding style. @Andreagit97 started an effort a while ago #470. Perhaps more folks can help, such as yourself @sgaist or @federico-sysdig and @falcosecurity/libs-maintainers?

@poiana
Copy link
Contributor

poiana commented Jun 12, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@incertum
Copy link
Contributor

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Sep 11, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Sep 11, 2024

/remove-lifecycle stale
/help

@poiana
Copy link
Contributor

poiana commented Sep 11, 2024

@leogr:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/remove-lifecycle stale
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@poiana poiana added help wanted Extra attention is needed and removed lifecycle/stale labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants