Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracking] Improve code documentation #3138

Closed
sgaist opened this issue Mar 13, 2024 · 8 comments
Closed

[tracking] Improve code documentation #3138

sgaist opened this issue Mar 13, 2024 · 8 comments

Comments

@sgaist
Copy link
Contributor

sgaist commented Mar 13, 2024

This ticket is a follow up of today's community meeting (and heavily inspired from falcosecurity/libs#1747.

TLDR: improve the code base documentation so that new (and old) contributors have an easier time going through it.

The longer story: while the falco code base is not void of documentation, it's also not completely documented and there are often a mix of doxygen and documentation formatted as comments (not related to comments in code). This make understanding how things are working more complicated than needed.

While the application itself is not a library to be used by others, the people wanting to work on the code would benefit from having it better documented. This helps working on bug fixes and features without requiring to read through all the implementation to understand how things are used.

There are several (complimentary) ways that this could be achieved:

  • Each time someone modifies a function that is not yet documented, add it
  • Each time a new API is added, mandatory document it
  • Have documentation sprints where people gather to do just that: take the time to document

This does not need to be the work of a single person.

One thing that could be done in that context is the creation of a group/team of people interested in this topic. They could help plan out the work on the long term, prepare guidelines, help review submission (style is as important as accuracy), etc. This would allow to have a consistent work done through all the Falco projects.

@incertum
Copy link
Contributor

Fully supportive, see also my comment in the libs equivalent ticket falcosecurity/libs#1747 (comment).

@sgaist
Copy link
Contributor Author

sgaist commented Mar 15, 2024

As an example of something that should be part of the contributor documentation: https://falco.org/blog/intro-development-falco/
The simple trick for using a local checkout of falcosecurity/libs is very handy when one wants to prepare a new feature for falco based on unreleased changes in libs and I think should be part of a "Getting started to hack on Falco" document which is different from "Building Falco from sources".

@poiana
Copy link
Contributor

poiana commented Jun 13, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@incertum
Copy link
Contributor

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Sep 11, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Oct 11, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@poiana
Copy link
Contributor

poiana commented Nov 10, 2024

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana
Copy link
Contributor

poiana commented Nov 10, 2024

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@poiana poiana closed this as completed Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants