fix(cmd/artifact/follow): colored output despite --disable-styling
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mickaël Fontès <[email protected]>
MickaelFontes
force-pushed
the
fix_style_output
branch
from
b09be83
to
d863957
Compare
alacuku
approved these changes
Sep 15, 2023
|
LGTM label has been added. Git tree hash: 715cefb303e057d38dc00ace4ef8555b4329b9bc
|
leogr
approved these changes
Sep 15, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, leogr, MickaelFontes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area cli
What this PR does / why we need it:
Output of the
artifact followcommand still contains colors even when the--disable-stylingflag is present.This PR removes the colors but still maintains "styling", which consists here in prepending each line with the log level and the artifact path.
Which issue(s) this PR fixes:
Fixes #295
Special notes for your reviewer:
This is a simple fix for the color issue I observed and encountered, but the logic problem of the
--disable-stylingflag not respected remains.I don't know if it is a problem or not.