new(pkg/runner/helper): added SpawnAsWithSymlink and modified SpawnAs to make a copy #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogr
reviewed
Apr 4, 2024
There was a problem hiding this comment.
I like it, but I'd not change the func signature.
So I suggest the following:
- copy the binary in
SpawnAsby default without changing theSpawnAssignature (also, no need to change the actions, it's basically just a stronger approach, but the end result is the same) - add a new
SpawnAsWithSymlinkfunc which is the weaker version of the method
wdyt?
loresuso
force-pushed
the
spawn-copy
branch
2 times, most recently
from
f3a33e6 to
f8c59cc
Compare
|
We should be good now @leogr, mind to take a look? :) |
… binary This can be used to trigger rules that are based on proc.exepath rather than proc.name for better detection purposes. Signed-off-by: Lorenzo Susini <[email protected]>
leogr
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, loresuso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: d5d5a67388982394ddc7aeb0b96c09a57122a831
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to copy or symlink the binary
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area pkg
What this PR does / why we need it:
The change introduced by this PR can be used to trigger rules that are based on proc.exepath rather than proc.name for better detection purposes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: