Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an event for default rule "Container Drift Detected (open+create)" #189

Merged

Conversation

GLVSKiriti
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
Added an event for default rule "Container Drift Detected (open+create)" as mentioned here

Which issue(s) this PR fixes:

Fixes #181

Special notes for your reviewer:

@GLVSKiriti
Copy link
Contributor Author

@FedeDP Similarly I executed this code in a go container and it triggers the rule

conatinerdriftviaopencreate

@leogr
Copy link
Member

leogr commented Apr 5, 2024

@FedeDP Similarly I executed this code in a go container and it triggers the rule

conatinerdriftviaopencreate

From your screenshot, it looks like the rule is triggered when Go is building the executable, and not when running it, doesn't it? 🤔
(I guess this happened because the other rule File opened below root... is shadowing the Container drift one... pls try to create and run it within /tmp).

@GLVSKiriti
Copy link
Contributor Author

GLVSKiriti commented Apr 5, 2024

@leogr I updated the code now. In the below screenshot, first log is triggered when go is building the executable and 2nd log is triggered when running the event

newcontainerDriftviaopencreate

@poiana poiana added the lgtm label Apr 5, 2024
@poiana
Copy link

poiana commented Apr 5, 2024

LGTM label has been added.

Git tree hash: a24c105f9d3cf422ec2cfeadb309ceb858fe847c

@poiana
Copy link

poiana commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GLVSKiriti, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Apr 5, 2024
@GLVSKiriti GLVSKiriti requested a review from leogr April 5, 2024 13:35
@poiana poiana merged commit 17bacf7 into falcosecurity:main Apr 5, 2024
4 checks passed
@GLVSKiriti GLVSKiriti deleted the ContainerDriftDetectedOpenCreate branch April 5, 2024 15:15
@leogr leogr added this to the v0.12.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an event for default rule "Container Drift Detcted"
3 participants