Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an event for default rule "Kubernetes Client Tool Launched in Container" #169

Merged

Conversation

GLVSKiriti
Copy link
Contributor

@GLVSKiriti GLVSKiriti commented Mar 20, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
Added an event for default rule "Kubernetes Client Tool Launched in Container" as mentioned here

Which issue(s) this PR fixes:

Fixes #168

Special notes for your reviewer:

@GLVSKiriti
Copy link
Contributor Author

@FedeDP @leogr Just by running the kubectl the rule triggers

KubernetesCLientToolLaunchedInContainer

And the docker file I used is

FROM alpine:latest

# Install dependencies
RUN apk add --no-cache curl

# Install kubectl
RUN curl -LO "https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl" \
    && chmod +x kubectl \
    && mv kubectl /usr/local/bin/

CMD ["sh"]

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
/approve

@poiana
Copy link

poiana commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, GLVSKiriti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Apr 2, 2024

LGTM label has been added.

Git tree hash: 044d51c9bf689090c9eb8b5089fbfc289248f4c4

@poiana poiana added the approved label Apr 2, 2024
@poiana poiana merged commit d96836b into falcosecurity:main Apr 2, 2024
4 checks passed
@GLVSKiriti GLVSKiriti deleted the kubernetesClientToolLaunchedInContainer branch April 2, 2024 12:53
@leogr leogr added this to the v0.12.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an event on default rule "Kubernetes Client Tool Launched in Container"
4 participants