-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an event for default rule "Adding ssh keys to authorized_keys" #117
Added an event for default rule "Adding ssh keys to authorized_keys" #117
Conversation
Signed-off-by: GLVS Kiriti <[email protected]>
Signed-off-by: GLVS Kiriti <[email protected]>
Signed-off-by: GLVS Kiriti <[email protected]>
Signed-off-by: GLVS Kiriti <[email protected]>
|
||
func AddingSshKeysToAuthorizedKeys(h events.Helper) error { | ||
// Creates temporary data for testing. | ||
directoryname := "/home/created-by-falco-event-generator/.ssh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same concerns as #112 applies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did the changes! Used the utility function used in #112 PR
Signed-off-by: GLVS Kiriti <[email protected]>
…logic Signed-off-by: GLVS Kiriti <[email protected]>
…e to remove code redundancy Signed-off-by: GLVS Kiriti <[email protected]>
Signed-off-by: GLVSKiriti <[email protected]>
Signed-off-by: GLVS Kiriti <[email protected]>
@FedeDP Similarly updated this also ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 63583cb6d564c7f611d7334451eb1a7aefe5b167
|
Signed-off-by: GLVS Kiriti <[email protected]>
2b12788
to
8b4feb4
Compare
@FedeDP Kindly add lgtm label again. As previously the build fails bcz createSshDirectoryUnderHome not exists so I merged main branch now it is ok!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 58d3682abf4d8404bc0ec4a014f645d55e49606f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, GLVSKiriti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area events
What this PR does / why we need it:
Added an event for default rule "Adding ssh keys to authorized_keys"
Which issue(s) this PR fixes:
Fixes #116
Special notes for your reviewer: