Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): Generate release notes #773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

syphernl
Copy link

@syphernl syphernl commented Nov 7, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area falco-talon

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

Enables release note generation via an option provided by chart-releaser. chart-releaser uses GitHub's feature for automatic release note generation (docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/documentation Improvements or additions to documentation dco-signoff: no area/falco-chart labels Nov 7, 2024
@poiana
Copy link
Contributor

poiana commented Nov 7, 2024

Welcome @syphernl! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana requested review from alacuku and bencer November 7, 2024 08:36
@poiana poiana added the size/XS label Nov 7, 2024
@leogr
Copy link
Member

leogr commented Dec 10, 2024

Hey @syphernl

Could you sign off your commits, please?

🙏

@leogr
Copy link
Member

leogr commented Dec 13, 2024

I just rebased to resolve the merge commit issue.

/hold summoning other @falcosecurity/charts-maintainers for a second look/opinion

@@ -0,0 +1,3 @@
# Enable automatic generation of release notes using GitHubs release notes generator.
# see: https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
generate-release-notes: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: new line

@poiana
Copy link
Contributor

poiana commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, syphernl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Dec 13, 2024

LGTM label has been added.

Git tree hash: 3d6c73190e1d67db199b3eef39c93b07c8739819

@cpanato
Copy link
Member

cpanato commented Dec 13, 2024

/hold for others

@cpanato
Copy link
Member

cpanato commented Dec 13, 2024

can lift if dont need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants