fix: only prints env key if there are env values to be passed. #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @jcchavezs! It looks like this is your first PR to falcosecurity/charts 🎉 |
jcchavezs
force-pushed
the
fixes_env_condition
branch
from
93962d1 to
71299b3
Compare
|
Hi @jcchavezs, thanks for the contribution. Please follow the steps described in the |
poiana
added
dco-signoff: no
do-not-merge/contains-merge-commits
size/M
and removed
dco-signoff: yes
size/XS
labels
jcchavezs
force-pushed
the
fixes_env_condition
branch
from
a41810e to
4b60f94
Compare
jcchavezs
force-pushed
the
fixes_env_condition
branch
from
4b60f94 to
9a8f618
Compare
|
Done @alacuku |
alacuku
reviewed
Oct 28, 2024
Signed-off-by: José Carlos Chávez <[email protected]>
jcchavezs
force-pushed
the
fixes_env_condition
branch
from
9a8f618 to
1b14d81
Compare
|
LGTM label has been added. Git tree hash: 6ed0dab75a1263ecf1081ea1604222680bc33ffd
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, jcchavezs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind chart-release
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
Which issue(s) this PR fixes:
Outputting the env key without values is highlighted as error in vscode.
Fixes #
Special notes for your reviewer:
Checklist