-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to add annotations to the metrics service #737
Add possibility to add annotations to the metrics service #737
Conversation
Hi, To be a valid PR, a few steps remain:
Moreover, wdyt to also add the possibility to ad custom labels, useful for the prometheus operator and else? Thanks |
Of course, doing it ! |
29eae99
to
50e3799
Compare
Sorry, I forgot to mention you need to sign off your commits, you can squash them and sign only the remaining |
yes done ! @Issif ;) |
There's an error in the CI:
|
263967a
to
394ef47
Compare
77679f1
to
394ef47
Compare
4d110b7
to
394ef47
Compare
394ef47
to
5fe809f
Compare
It's only failing with labels isn't it @Issif ? |
@alacuku Thx 🙏 |
Yeah, create the file and then you can adapt the tests from: https://github.com/falcosecurity/charts/blob/master/charts/falco/tests/unit/serviceMonitorTemplate_test.go In this case, we need to check that:
I suggest you test the labels and annotations separately. |
I'm working on tests @alacuku but I have few questions :
|
Here you go:
|
An example how can you set custom variable:
|
@alacuku Here is the first draft for labels. |
The CI is failing. Could you have a look? |
Yes but I wanted to first know if the code seems ok at a first look for you :) @alacuku |
Yeah, it's ok! |
e33c17f
to
8a24a0c
Compare
Does the CICD launches alone @alacuku ? |
It seems that I have an issue with the typing of the helm options with the key/values of the labels 😬 |
yes indeed, how to put some labels with the helm options @alacuku ? That's what is getting the CI failing :/ |
@alacuku any update here ? |
1fc55fd
to
ce4c7ac
Compare
Signed-off-by: afreyermuth98 <[email protected]> :wrench: Resolving conflicts Signed-off-by: afreyermuth98 <[email protected]> :bug: Fixing CI Signed-off-by: afreyermuth98 <[email protected]> :bug: Missing dot before Values Signed-off-by: afreyermuth98 <[email protected]> :wrench: Conflicts Signed-off-by: afreyermuth98 <[email protected]> :bug: Removed extra space Signed-off-by: afreyermuth98 <[email protected]> :wrench: Reviews Signed-off-by: afreyermuth98 <[email protected]> :bug: Extra toYaml Signed-off-by: afreyermuth98 <[email protected]> :wrench: Working on tests Signed-off-by: afreyermuth98 <[email protected]> :wrench: Reviews Signed-off-by: afreyermuth98 <[email protected]> :wrench: Annotation test + duplicate chartInfo Signed-off-by: afreyermuth98 <[email protected]> :wrench: Ref to options Signed-off-by: afreyermuth98 <[email protected]> :bug: Helm options type Signed-off-by: afreyermuth98 <[email protected]> :wrench: Patch Signed-off-by: afreyermuth98 <[email protected]> :bug: Fixed bad conflicts resolution Signed-off-by: afreyermuth98 <[email protected]> :arrow_up: Bump chart version Signed-off-by: afreyermuth98 <[email protected]>
26db278
to
1c53b6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 6ded0ea5beeb33493a8c683c7d24fda80143855f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreyermuth98, alacuku, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I want to add the possibilty to put annotations on the metrics service to be scraped by my OTEL collector
What type of PR is this?
Any specific area of the project related to this PR?
What this PR does / why we need it:
We need it to scrape the metrics with an external service monitor
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist