Fix existing client secret check #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
|
Welcome @orange-llajeanne! It looks like this is your first PR to falcosecurity/charts 🎉 |
|
Hi @orange-llajeanne, thanks for the PR. Could you please rebase on main? |
Signed-off-by: Loïc Lajeanne <[email protected]>
Signed-off-by: Loïc Lajeanne <[email protected]>
orange-llajeanne
force-pushed
the
fix_existingClientSecret_check
branch
from
2ff8a22 to
41c3254
Compare
|
@alacuku Hi, I've rebased my branch and updated the version number |
|
@orange-llajeanne, it would help if you run a |
Signed-off-by: Loïc Lajeanne <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, orange-llajeanne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: f1a67d6f4487f65d658fe3cac7509629a1b6cc99
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind chart-release
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
This PR fixes a check in the falco pod template, which uses the
existingSecretvariable instead ofexistingClientSecretwhen deciding if client secrets are enabled.The consequence was that the chart would not work correctly when defining
existingSecretbut notexistingClientSecret: it would try to attach an unexisting configmap to falco podsChecklist