-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : falcosidekick service monitor update add aditionnal properties #670
Conversation
Signed-off-by: Arnaud CHATELAIN <[email protected]>
charts/falcosidekick/README.md
Outdated
@@ -574,6 +574,7 @@ The following table lists the main configurable parameters of the Falcosidekick | |||
| service.port | int | `2801` | Service port | | |||
| service.type | string | `"ClusterIP"` | Service type | | |||
| serviceMonitor.additionalLabels | object | `{}` | specify Additional labels to be added on the Service Monitor. | | |||
| serviceMonitor.additionalProperties | object | `{}` | aditionalProperties allows setting additional properties on the endpoint such as relabelings, metricRelabelings etc. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| serviceMonitor.additionalProperties | object | `{}` | aditionalProperties allows setting additional properties on the endpoint such as relabelings, metricRelabelings etc. | | |
| serviceMonitor.additionalProperties | object | `{}` | allow setting additional properties on the endpoint such as relabelings, metricRelabelings etc. | |
Signed-off-by: Arnaud CHATELAIN <[email protected]>
…s and Fix prometheus rules Signed-off-by: Arnaud CHATELAIN <[email protected]>
Co-authored-by: Thomas Labarussias <[email protected]> Signed-off-by: ArnaudCHT <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArnaudCHT, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 879fb4e853ab9a745da22a6a9679084717753fc0
|
What type of PR is this?
/kind feature
/kind chart-release
Any specific area of the project related to this PR?
/area falcosidekick-chart
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I run a helm template, helm lint helm dry-run to test and try the serviceMonitor on Openshift cluster. Test the prometheusRule on grafana.
Checklist