-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOTES.txt: Fix links #620
NOTES.txt: Fix links #620
Conversation
Welcome @schnatterer! It looks like this is your first PR to falcosecurity/charts 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. To pass the CI, you need to bump up the chart version and update the changelog too.
Hi @schnatterer, could you please run |
Signed-off-by: Johannes Schnatterer <[email protected]>
Thanks, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
LGTM label has been added. Git tree hash: 29d32b87396ad3b4a9f31635f90b64379e257bc5
|
@Issif, con you have a look? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, Issif, schnatterer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks |
What type of PR is this?
/kind documentation
/kind chart-release
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
Fixes links in output after falco install without sidekick
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist