Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOTES.txt: Fix links #620

Merged
merged 1 commit into from
Feb 13, 2024
Merged

NOTES.txt: Fix links #620

merged 1 commit into from
Feb 13, 2024

Conversation

schnatterer
Copy link
Contributor

@schnatterer schnatterer commented Feb 12, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:
Fixes links in output after falco install without sidekick

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/documentation Improvements or additions to documentation dco-signoff: yes area/falco-chart labels Feb 12, 2024
@poiana
Copy link
Contributor

poiana commented Feb 12, 2024

Welcome @schnatterer! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana requested review from alacuku and bencer February 12, 2024 15:40
@poiana poiana added the size/XS label Feb 12, 2024
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. To pass the CI, you need to bump up the chart version and update the changelog too.

@alacuku
Copy link
Member

alacuku commented Feb 13, 2024

Hi @schnatterer, could you please run make docs-falco and then push again?

Signed-off-by: Johannes Schnatterer <[email protected]>
@schnatterer
Copy link
Contributor Author

Thanks, done.
The option in the PR template /kind chart-release lead me to believe you might not release every change.
I had a look at the CONTRIBUTING.md but missed the make docs mentioned in README.md.
You could adapt those in the PR template to make it easier for new contributors 🙂

Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@poiana
Copy link
Contributor

poiana commented Feb 13, 2024

LGTM label has been added.

Git tree hash: 29d32b87396ad3b4a9f31635f90b64379e257bc5

@alacuku
Copy link
Member

alacuku commented Feb 13, 2024

@Issif, con you have a look?

@poiana
Copy link
Contributor

poiana commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, Issif, schnatterer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Issif
Copy link
Member

Issif commented Feb 13, 2024

Thanks

@poiana poiana merged commit b5f79e2 into falcosecurity:master Feb 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants