Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upate(k8s-metacollector): update the chart's info #592

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Dec 21, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

What this PR does / why we need it:

Update the chart's info and add the work-in-progress disclaimer in the README.md file.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added dco-signoff: yes kind/documentation Improvements or additions to documentation kind/chart-release Add this label when the chart version has been bumped labels Dec 21, 2023
@poiana poiana requested review from bencer and Issif December 21, 2023 08:35
@poiana poiana added the size/M label Dec 21, 2023
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@poiana
Copy link
Contributor

poiana commented Dec 21, 2023

LGTM label has been added.

Git tree hash: c2f28dff5d41d0a99716f60b363c94d9bb91fd1f

@poiana
Copy link
Contributor

poiana commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b182b74 into falcosecurity:master Dec 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped kind/documentation Improvements or additions to documentation lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants